Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(NODE-6191): clarify that operations should not be parallelized in transactions #4122

Merged
merged 3 commits into from
May 28, 2024

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented May 28, 2024

Description

What is changing?

Add inline documentation detailing that Promise.all and other concurrency mechanisms should not be used to parallelize transaction operations

Is there new documentation needed for these changes?

No

What is the motivation for this change?

NODE-6191

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James marked this pull request as ready for review May 28, 2024 18:34
@aditi-khare-mongoDB aditi-khare-mongoDB self-assigned this May 28, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 28, 2024
src/sessions.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tiny nit comment you can fix if you want to. I'll merge by EOD regardless.

Co-authored-by: Aditi Khare <106987683+aditi-khare-mongoDB@users.noreply.github.com>
@W-A-James
Copy link
Contributor Author

Fixed 👍🏿

@aditi-khare-mongoDB aditi-khare-mongoDB merged commit d3031a5 into main May 28, 2024
23 of 28 checks passed
@aditi-khare-mongoDB aditi-khare-mongoDB deleted the NODE-6191 branch May 28, 2024 20:08
fiws added a commit to fiws/mongoose that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants